ts-sdk: Add time-based lru caching for the decryptChannelDEK#25
Open
ioannischtz wants to merge 8 commits into
Open
ts-sdk: Add time-based lru caching for the decryptChannelDEK#25ioannischtz wants to merge 8 commits into
ioannischtz wants to merge 8 commits into
Conversation
…gination in the integration-write test
…achments. chore(ts-sdk): cleanup the integration tests.
nikos-kitmeridis
approved these changes
Sep 23, 2025
| this.#sessionKey = config.sessionKey; | ||
| this.#sessionKeyConfig = config.sessionKeyConfig; | ||
| this.#encryptionPrimitives = config.encryptionPrimitives ?? WebCryptoPrimitives.getInstance(); | ||
| this.#dekCache = new TimeBasedLruCache({ ttlMs: 5 * 60 * 1000, maxEntries: 100 }); // 5 minutes TTL, 100 max entries |
Collaborator
There was a problem hiding this comment.
this should be configurable. let's open a ticket for that.
| ]; | ||
|
|
||
| // Use cache with loader function | ||
| return await this.#dekCache.read(cacheKey, async (): Promise<SymmetricKey> => { |
Collaborator
There was a problem hiding this comment.
I think that, await is not needed here
| import { EncryptedObject, SessionKey } from '@mysten/seal'; | ||
| import { fromHex, isValidSuiObjectId, toHex } from '@mysten/sui/utils'; | ||
|
|
||
| import { TimeBasedLruCache } from '../cache.js'; |
Collaborator
There was a problem hiding this comment.
Do we need the suffix?
| } | ||
|
|
||
| export class TimeBasedLruCache { | ||
| #cache: Map<string, { value: unknown; timestampMs: number }>; |
Collaborator
There was a problem hiding this comment.
These 3 -> readonly
| } | ||
| this.#set(cacheKey, result); | ||
|
|
||
| return result as T; |
Collaborator
There was a problem hiding this comment.
as T is not needed I believe
Collaborator
There was a problem hiding this comment.
Are you gonna use these consts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decryptChannelDEKmethod, in order to significantly reduce redundant rpc requests.