Skip to content

Added Favicon!#91

Open
rishabh-bansal wants to merge 1 commit intoMozpacers:masterfrom
rishabh-bansal:master
Open

Added Favicon!#91
rishabh-bansal wants to merge 1 commit intoMozpacers:masterfrom
rishabh-bansal:master

Conversation

@rishabh-bansal
Copy link
Copy Markdown

No description provided.

* Adds @mbad0la to list of Contributors

* Added Favicon

* Added Favicon
Comment thread index.html
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Favicons -->
<link rel="shortcut icon" href="favicon.ico">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is favicon added?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added favicon.ico in root directory, please check.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see that in this PR. Can you please push your changes?

Copy link
Copy Markdown
Member

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-bansal Hi, thank you for contributing. You have unintended changes which should not be part of this pull request (Because of master branch). Please create a separate branch and make changes to that before sending a pull request.

Comment thread CONTRIBUTORS.txt
Aditya Chawla (gh: chawlaaditya8)
Vipin Khushu (gh: vipinkhushu)
Saurabh Badhwar (gh: h4xr)
Mayank Badola (gh: mbad0la)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be part of this pull request.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update your branch with latest master changes.

@CuriousLearner CuriousLearner changed the base branch from master to develop December 9, 2017 19:23
@CuriousLearner CuriousLearner changed the base branch from develop to master December 9, 2017 19:23
Comment thread index.html
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Favicons -->
<link rel="shortcut icon" href="favicon.ico">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see that in this PR. Can you please push your changes?

Comment thread CONTRIBUTORS.txt
Aditya Chawla (gh: chawlaaditya8)
Vipin Khushu (gh: vipinkhushu)
Saurabh Badhwar (gh: h4xr)
Mayank Badola (gh: mbad0la)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update your branch with latest master changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants