John palmer patch space time resolution#2
Open
JohnPalmer wants to merge 10 commits intoOmatech_v1.50+from
Open
John palmer patch space time resolution#2JohnPalmer wants to merge 10 commits intoOmatech_v1.50+from
JohnPalmer wants to merge 10 commits intoOmatech_v1.50+from
Conversation
Changed values for background tracking cells - lat and lon and area.
Changed values for background tracking cell lat, lon, and area.
Changed values for background tracking cell lat, lon, and area.
Changed values for background tracking cell lat, lon, and area.
Changed value for background tracking cell lat and lon.
Changed value for background tracking cell lat and lon.
Changed value for background tracking cell lat and lon.
Changed value for background tracking cell lat and lon.
Changed latMask and lonMask variables to 0.025. These will be used in the mask implemented by FixUse.java.
Temporal Information stored from each background fix will now be the hour only (but still stored as a long to avoid any problems in other parts of the cose)
Collaborator
|
Ok, it's fine John. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made here all of the changes in steps 1-3 of my email from 20 June. They are pretty straight forward, but please test that my change of the time stored by FixUse.java does not mess anything up. Instead of storing the exact time of the fix, we are now grabbing the hour as an integer and then storing it in the new Fix as a long (since I keeping the type the same should avoid problems in other parts of the code, where we expect a long). But I have not tested this so it is possible that things will go wrong (e.g. if the fix for some reason has a null value for time, this may throw an error when we change from int to long).