Add comprehensive test coverage for PyNeb core classes and utilities#74
Closed
Copilot wants to merge 1 commit into
Closed
Add comprehensive test coverage for PyNeb core classes and utilities#74Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
…agnostics, EmisGrid, Continuum, ICF, and utils Agent-Logs-Url: https://github.com/Morisset/PyNeb_devel/sessions/9dd8ab0b-432f-4824-ba61-fea31922afcf Co-authored-by: Morisset <442951+Morisset@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Morisset
April 7, 2026 16:14
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase had only 3 tests covering basic object instantiation attributes, leaving ~10,000 lines of core library functionality with zero functional test coverage. This PR adds 9 new test files bringing the total from 3 to 215 tests.
New test files
tests/test_atom.py—Atom:getA,getOmega,getCollRates,getStatWeight,getEnergy,getTransition,getPopulations,getCritDensity,getEmissivity,getTemDen,getIonAbundance, density ratio limits, scalar/array/product-mode variants, reprtests/test_recatom.py—RecAtom: H1/He1/He2 instantiation,getEmissivity(scalar, array, product/non-product modes),getIonAbundance,getTransition, Case A vs Btests/test_observation.py—Observation/EmissionLine:addLine,removeLine,getLine,getIntens,getSortedLines,getUniqueAtoms,addMonteCarloObs,fillObs,correctIntenstests/test_redcorr.py—RedCorr:getCorr/getCorrHbacross multiple laws,getErrCorr,setCorr,cHbetaFromEbv↔EbvFromCHbetaroundtrips, AV/E_BV property setterstests/test_diagnostics.py—Diagnostics:addAll,addDiag(builtin/custom/list/by-atom),delDiag,getCrossTemDen,eval_diag,addClabel,setAtomstests/test_emis_grid.py—EmisGrid: grid shape/range invariants,getGridby levels/wavelength/expressiontests/test_continuum.py—Continuum:gff,two_photon(including Ly-α cut-off physics),FreeFree,get_continuumtests/test_icf.py—ICF:getAvailableICFs,addICF/delICF,getExpression,getReference/getURL,getElemAbundancetests/test_utils_misc.py—int_to_roman/roman_to_introundtrips,parseAtom,strExtract,quiet_divide,vactoair↔airtovacroundtrip