feat(baker+ci): substrate coverage checker + ambientcg JPG fallback (#293)#444
Open
gerchowl wants to merge 1 commit into
Open
feat(baker+ci): substrate coverage checker + ambientcg JPG fallback (#293)#444gerchowl wants to merge 1 commit into
gerchowl wants to merge 1 commit into
Conversation
…293) Wire up the "wanted vs actual" substrate coverage checker that compares the canonical release matrix + upstream catalogs against live HF state. New: - scripts/check_substrate_coverage.py — CLI + Dagger function - tests/test_check_substrate_coverage.py — 24 tests Changed: - ambientcg adapter: JPG fallback in _TIER_ATTRS + JPG→PNG conversion at extraction time (unlocks 28 previously unbakeable materials) - snapshot_upstream_catalog: add physicallybased to _ids_for_source() - Dagger: add check_substrate_coverage() function Closes #293
github-actions
Bot
added
area:testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check_substrate_coverage.py) — compares canonical release matrix + upstream material catalogs against live HF substrate state. Reports per-(source, tier) coverage: missing tiers, missing material IDs, unexpected extras._TIER_ATTRSnow tries PNG first, falls back to JPG. JPG→PNG conversion at extraction time via PIL. Unlocks 28 previously unbakeable materials (1949 → 1977 bakeable).check_substrate_coverage()wraps the script for CI pipelines._ids_for_source()now handles all 4 sources.What it found on
gerchowl/mat-vis-tst@v2026.04.99-tst-full-369Test plan
uv run pytest tests/test_check_substrate_coverage.py -v— 24 passedruff check— cleangerchowl/mat-vis-tst— produces correct coverage reportAsphalt001JPG ZIP, extracted 4 channels as PNG (1024x737)test_release_registry,test_release_matrix,test_check_upstream_content_drift(82 passed)🤖 Generated with Claude Code