Skip to content

[202_111] display the shortcut keys corresponding to the symbols in the right footer#2933

Merged
MoonL79 merged 4 commits intoMoganLab:mainfrom
Prthmsh7:202_106_display_symbol_Shortcuts
Mar 5, 2026
Merged

[202_111] display the shortcut keys corresponding to the symbols in the right footer#2933
MoonL79 merged 4 commits intoMoganLab:mainfrom
Prthmsh7:202_106_display_symbol_Shortcuts

Conversation

@Prthmsh7
Copy link
Contributor

@Prthmsh7 Prthmsh7 commented Mar 5, 2026

PR for #2886

Before :
Screenshot 2026-02-28 at 2 17 45 AM

After :
Screenshot 2026-02-28 at 2 32 56 AM

Root cause: The footer had no mechanism to look up or display keyboard shortcuts
Fix: Added get_shortcut_suffix() which calls Scheme's kbd-find-inv-binding to resolve the shortcut for symbols, and used the existing kbd_shortcut() for operations which appends the result as [Shortcut] in the right footer.

How to Test

  1. Open a document in the editor.
  2. Move the cursor to a position where a symbol is present.
  3. Verify that the right footer displays the corresponding keyboard shortcut.
  4. Move the cursor away from the symbol and confirm that the footer clears.

@Prthmsh7
Copy link
Contributor Author

Prthmsh7 commented Mar 5, 2026

@MoonL79 Hi, I’ve resolved the numbering conflict and updated the devel entry as requested. The previous PR (#2892) closed after the force push during rebase, so I’ve reopened the changes here. Please let me know if any further adjustments are needed. Thank you.

Copy link
Contributor

@MoonL79 MoonL79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoonL79 MoonL79 merged commit 73f601a into MoganLab:main Mar 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants