Add support for passing tokens in Apache Arrow Flight Tester#58
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Apache Arrow Flight Tester client so it can optionally attach a bearer token to Flight requests (enabling authenticated testing against ModelarDB), while also aligning schema/protobuf definitions with newer upstream expectations.
Changes:
- Add optional bearer-token support to the Flight client wrapper and propagate the token to workload-balanced cloud-node queries.
- Update string column types in test schemas from
utf8()tostring_view(). - Update ModelarDB protocol buffers and generated Python stubs to include new configuration fields.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Apache-Arrow-Flight-Tester/wrapper.py | Adds client middleware factory/middleware for bearer-token auth and wires it into FlightClientWrapper. |
| Apache-Arrow-Flight-Tester/server.py | Reads token from MODELARDB_TOKEN, passes it into the server client, and propagates it to cloud-node clients. |
| Apache-Arrow-Flight-Tester/util.py | Updates test table schemas to use pyarrow.string_view() for string columns. |
| Apache-Arrow-Flight-Tester/protobuf/protocol.proto | Adds new configuration fields and updates enum/settings. |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.pyi | Regenerated typing stubs reflecting updated protobuf schema. |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py | Regenerated protobuf runtime module reflecting updated serialized descriptors. |
Files not reviewed (1)
- Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skejserjensen
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing a bearer token when testing the different endpoints in the Apache Arrow Flight Tester. The PR also fixes a type issue related to utf8, updates the dependencies, and updates the protocol buffers to the latest version.
Note that since this functionality relies on the new auth support in ModelarDB, it should not be merged before ModelarData/ModelarDB-RS#405 is merged.