Use uint64 in C-API instead of string workaround#409
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the modelardb_embedded C-API (and its bindings) to accept optional uint64_t values for vacuum() retention period and optimize() target size, removing the prior string-based workaround.
Changes:
- Change the C-API functions
modelardb_embedded_vacuum()andmodelardb_embedded_optimize()to takeconst uint64_t*(nullable) instead ofconst char*. - Update the Rust C-API implementation to read optional
u64values directly from pointers. - Update the Python binding to pass
uint64_t*values via cffi for these parameters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/modelardb_embedded/src/capi.rs | Switch FFI parameter types from C strings to *const u64 and remove string parsing. |
| crates/modelardb_embedded/bindings/python/modelardb/operations.py | Update Python cffi calls to pass uint64_t* instead of char[] strings. |
| crates/modelardb_embedded/bindings/c/modelardb_embedded.h | Update C header signatures to use const uint64_t* for the optional arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skejserjensen
approved these changes
Jul 6, 2026
chrthomsen
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the C-API and C header to use unsigned 64-bit integers for the vacuum() and optimize() arguments instead of the previous workaround that used a string and converted the string to u64 in the C-API.