feat: add native uninstaller (closes #38)#39
Merged
Conversation
Adds `mobilecli uninstall`, which reverses everything install.sh and the setup wizard put in place: - stops the running daemon - removes daemon autostart (systemd / launchd / Task Scheduler) - strips the shell auto-launch hook from rc files - deletes the config dir (~/.mobilecli, incl. paired credentials) - removes the binary itself (Unix unlink-while-running; Windows best-effort) Flags: --yes (skip prompt), --keep-config, --keep-binary. Also adds a standalone uninstall.sh for parity with install.sh: it delegates to `mobilecli uninstall` when the binary is present and falls back to manual cleanup otherwise. README documents both paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Mirror the existing install.sh `bash -n` gate so the uninstaller script is validated in the same release pipeline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bigph00t
force-pushed
the
feat/native-uninstaller
branch
from
e144aff to
167c790
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #38 — adds a built-in uninstaller so users no longer have to read
install.shto figure out how to undo an install.mobilecli uninstallreverses everythinginstall.shand the setup wizard put in place:autostart uninstalllogicautolaunch uninstalllogic~/.mobilecli, including paired credentials, sessions, logs, uploads)Flags
-y/--yes— skip the confirmation prompt--keep-config— preserve~/.mobilecli--keep-binary— leave the binary in placeStandalone script
Adds
uninstall.shfor parity withinstall.sh. It delegates tomobilecli uninstall --yeswhen the binary is on PATH, and falls back to manual cleanup (daemon, systemd/launchd, shell hooks, config dir, binary) when the binary is missing or broken.README documents both the native command and the curl one-liner.
Test plan
cargo build/cargo clippycleancargo test— 74 passedmobilecli uninstall --helpand the confirmation/cancel path manuallybash -n uninstall.shpasses🤖 Generated with Claude Code