Return image ID in PullImageResponse.image_ref to stay compatible with future k8s versions#549
Merged
Merged
Conversation
stlaz
requested review from
athongsamai,
awmirantis and
smerkviladze
as code owners
Contributor
Author
|
@athongsamai you seem to have been the latest person active in the repository as far as I can tell. If you could please review the PR or find somebody to do it, that'd be great. I posted more context into the #cri-dockerd channel on k8s Slack if needed. |
awmirantis
reviewed
May 15, 2026
stlaz
force-pushed
the
cri-image-ref
branch
2 times, most recently
from
4278f1d to
472122c
Compare
Contributor
Author
|
@awmirantis please run the CI. |
This is required to stay compatible with the latest CRI API requirements. Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Contributor
Author
|
@awmirantis thank you 🙇 I see I need a review from at least one other person with write access, would you be able to fetch anyone? If we manage to merge this, when could we expect a release with the fix? I would include it in kubernetes/website#54879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #546 and kubernetes/kubernetes#137024
Proposed Changes
bump cri-tools to current master instead of roughly 3 years old ref in integration GH action