feat(sdk): add optional OTLP tracing via tracing config option (#241)#246
Open
Ademiitura wants to merge 1 commit into
Open
feat(sdk): add optional OTLP tracing via tracing config option (#241)#246Ademiitura wants to merge 1 commit into
Ademiitura wants to merge 1 commit into
Conversation
- Add sdk/src/telemetry/tracing.ts with no-op default and OTLP/HTTP flush - Wrap register, deploy, signAuthEntry in withSpan for full payment lifecycle - Export TracingConfig type and shutdownTracing from sdk index - Add @opentelemetry packages as optional dependencies Closes Miracle656#241
|
@Ademiitura is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Ademiitura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #241 — optional OTLP tracing for SDK consumers self-hosting an OTel collector.
Changes
sdk/src/telemetry/tracing.ts(new) — no-op tracer by default, OTLP/HTTP flush when configuredsdk/src/useInvisibleWallet.ts— addedtracingoption toWalletConfig, wrapsregister,deploy, andsignAuthEntrywith spanssdk/src/index.ts— exportsTracingConfigtype andshutdownTracingsdk/package.json— adds OTel packages as optional dependenciesUsage
Acceptance criteria
tracingis not configuredveil.register,veil.deploy,veil.signAuthEntryCloses OTLP traces from SDK #241