GEOPY-2776: Relabel uijson for TEM using Vertical, inLine, cross-line#368
Open
domfournier wants to merge 5 commits intodevelopfrom
Open
GEOPY-2776: Relabel uijson for TEM using Vertical, inLine, cross-line#368domfournier wants to merge 5 commits intodevelopfrom
domfournier wants to merge 5 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes EM receiver component naming from legacy x/y/z to crossline/inline/vertical across TDEM/FDEM options, UI JSON labels/tooltips, receiver construction, and run tests to better align with survey-relative component terminology.
Changes:
- Renames/aliases TDEM & FDEM option fields to
vertical/inline/crosslinevariants using PydanticAliasChoices. - Updates receiver orientation handling to translate
vertical/inline/crosslineinto SimPEG’sz/y/xorientation codes. - Updates run tests and UI JSON labels/tooltips to use the new component naming.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/oriented_airborne_tem_receiver_test.py | Updates expected component group names to vertical/inline/crossline. |
| tests/run_tests/oriented_airborne_fem_receiver_test.py | Updates expected component group names to vertical/inline/crossline. |
| tests/run_tests/driver_airborne_tem_test.py | Updates test data/group naming and lookups to vertical. |
| tests/run_tests/driver_airborne_tem_1d_test.py | Updates test data/group naming and lookups to vertical. |
| tests/run_tests/driver_airborne_fem_test.py | Updates test data/group naming and lookups to vertical_*. |
| tests/run_tests/driver_airborne_fem_1d_test.py | Updates test data/group naming and lookups to vertical_*. |
| simpeg_drivers/electromagnetics/time_domain/options.py | Introduces vertical/inline/crossline option fields with aliases (but contains aliasing bugs). |
| simpeg_drivers/electromagnetics/time_domain_1d/options.py | Adds vertical_* aliases for 1D TDEM options. |
| simpeg_drivers/electromagnetics/frequency_domain/options.py | Adds vertical/inline/crossline aliases for FDEM options. |
| simpeg_drivers/electromagnetics/frequency_domain_1d/options.py | Adds vertical_* aliases for 1D FDEM options. |
| simpeg_drivers/components/factories/receiver_factory.py | Maps vertical/inline/crossline to z/y/x when building SimPEG receivers. |
| simpeg_drivers/components/data.py | Simplifies TDEM dB/dt normalization initialization to a full -1 array. |
| simpeg_drivers-assets/uijson/tdem1d_inversion.ui.json | Updates labels/tooltips to “Vertical”. |
| simpeg_drivers-assets/uijson/tdem1d_forward.ui.json | Updates labels/tooltips to “Vertical”. |
| simpeg_drivers-assets/uijson/tdem_inversion.ui.json | Updates labels/tooltips and swaps displayed meanings for x/y to crossline/inline. |
| simpeg_drivers-assets/uijson/tdem_forward.ui.json | Updates component labels/tooltips to Vertical/In-line/Cross-line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #368 +/- ##
===========================================
- Coverage 89.85% 89.85% -0.01%
===========================================
Files 125 125
Lines 6419 6424 +5
Branches 793 793
===========================================
+ Hits 5768 5772 +4
- Misses 448 449 +1
Partials 203 203
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2776 - Relabel uijson for TEM using Vertical, inLine, cross-line