Skip to content

Switch to defusedxml for secure XML parsing in skills and evaluation harness #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch to defusedxml for secure XML parsing in skills and evaluation harness #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mini_agent/skills/document-skills/docx/ooxml/scripts/validation/redlining.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def validate(self):

# First, check if there are any tracked changes by Claude to validate
try:
import xml.etree.ElementTree as ET
import defusedxml.etree.ElementTree as ET

tree = ET.parse(modified_file)
root = tree.getroot()
Expand Down Expand Up @@ -81,7 +81,7 @@ def validate(self):

# Parse both XML files using xml.etree.ElementTree for redlining validation
try:
import xml.etree.ElementTree as ET
import defusedxml.etree.ElementTree as ET

modified_tree = ET.parse(modified_file)
modified_root = modified_tree.getroot()
Expand Down
6 changes: 3 additions & 3 deletions mini_agent/skills/document-skills/pptx/ooxml/scripts/validation/redlining.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def validate(self):

# First, check if there are any tracked changes by Claude to validate
try:
import xml.etree.ElementTree as ET
import defusedxml.etree.ElementTree as ET

tree = ET.parse(modified_file)
root = tree.getroot()
Expand Down Expand Up @@ -79,9 +79,9 @@ def validate(self):
)
return False

# Parse both XML files using xml.etree.ElementTree for redlining validation
# Parse both XML files using defusedxml for redlining validation
try:
import xml.etree.ElementTree as ET
import defusedxml.etree.ElementTree as ET

modified_tree = ET.parse(modified_file)
modified_root = modified_tree.getroot()
Expand Down
2 changes: 1 addition & 1 deletion mini_agent/skills/mcp-builder/scripts/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import sys
import time
import traceback
import xml.etree.ElementTree as ET
import defusedxml.etree.ElementTree as ET
from pathlib import Path
from typing import Any

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ dependencies = [
"pipx>=1.8.0",
"anthropic>=0.39.0",
"openai>=1.57.4",
"defusedxml>=0.7.1",
"agent-client-protocol>=0.6.0",
]

Expand Down