Add Admin Role Separation#230
Open
MaryammAli wants to merge 1 commit into
Open
Conversation
Add Admin Role Separation
|
@MaryammAli Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a structured role-based administration system to improve governance, scalability, and long-term maintainability of the quest contract.
Previously, all privileged operations were centralized under a single owner account. While functional for smaller deployments, this approach becomes increasingly restrictive and difficult to manage as the platform grows and more contributors need operational access. It also creates unnecessary dependency on a single administrator for routine quest management tasks.
To address this, the contract now supports additional manager/moderator roles alongside the owner role. These managers are granted limited administrative capabilities focused specifically on quest operations, allowing them to create, update, and manage quests without receiving full ownership privileges over the contract.
The owner role remains the highest authority within the system and retains exclusive control over governance-sensitive actions such as assigning or revoking manager permissions. This ensures delegation can happen safely without compromising security or ownership integrity.
This separation of responsibilities provides several important improvements:
The implementation also improves maintainability by creating a cleaner authorization structure that can be extended more easily in future updates if additional roles or permissions are introduced.
Testing was performed to verify:
Overall, this update establishes a more flexible and production-ready administrative model for the platform while preserving strong security guarantees around ownership and governance.
Closes #207