Closed
Conversation
Owner
Author
|
@tmacychen I updated this PR to the new codebase. Question: I am wondering if it is better if we have something like Also, we should add some tests (to |
Owner
Author
|
On second thought I wonder if this should just be up to the user. Seems easier to just configure Let me know otherwise and I can reopen. |
|
Sorry for replying so late. I missed some messages. I’m agree with your suggestion. Thank you for continuing to maintain this tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving @tmacychen's PR nivekuil#40 to here for merging.
(Will be some conflicts that I will need to solve first)