Skip to content

fix: enables Decimal.sum(...[]) to return 0 instead throwing an error #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hunterwilhelm wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

fix: enables Decimal.sum(...[]) to return 0 instead throwing an error #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion decimal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4861,7 +4861,8 @@
function sum() {
var i = 0,
args = arguments,
x = new this(args[i]);
firstArg = args[i],
x = new this(firstArg === undefined ? 0 : firstArg);

external = false;
for (; x.s && ++i < args.length;) x = x.plus(args[i]);
Expand Down
3 changes: 2 additions & 1 deletion decimal.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4856,7 +4856,8 @@ function sub(x, y) {
function sum() {
var i = 0,
args = arguments,
x = new this(args[i]);
firstArg = args[i],
x = new this(firstArg === undefined ? 0 : firstArg);

external = false;
for (; x.s && ++i < args.length;) x = x.plus(args[i]);
Expand Down
3 changes: 2 additions & 1 deletion test/modules/sum.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ T('sum', function () {
t(11, -11);
t(1, '2', new Decimal(3), new Decimal('4'), -10);
t(new Decimal(-10), '9', new Decimal(0.01), 0.99);

t();

expected = new Decimal(10);

t('10');
Expand Down