Fix stale/inaccurate comments in UpdateVersion test cases#511
Merged
Conversation
…entation Co-authored-by: jgeurten <23045608+jgeurten@users.noreply.github.com> Agent-Logs-Url: https://github.com/MicrosoftDocs/WDAC-Toolkit/sessions/6c0a8b8c-31b6-4779-b9a7-baa99617b602
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on test cases for the Wizard
Fix stale/inaccurate comments in UpdateVersion test cases
Mar 20, 2026
jgeurten
approved these changes
Mar 23, 2026
jgeurten
added a commit
that referenced
this pull request
Mar 23, 2026
* Added test unit tests * Fixed version tests and logic * Added EKU and COM tests * Fixed EKU test * Update .gitignore * Update WDAC-Policy-Wizard/WDAC-Wizard.Tests/HelperTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update WDAC-Policy-Wizard/app/WDAC Wizard.sln Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix stale/inaccurate comments in UpdateVersion test cases (#511) * Initial plan * Fix stale comments in UpdateVersion test cases to match actual implementation Co-authored-by: jgeurten <23045608+jgeurten@users.noreply.github.com> Agent-Logs-Url: https://github.com/MicrosoftDocs/WDAC-Toolkit/sessions/6c0a8b8c-31b6-4779-b9a7-baa99617b602 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jgeurten <23045608+jgeurten@users.noreply.github.com> * Update .gitignore * Updated git ignore --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jgeurten <23045608+jgeurten@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test comments described a "double increment" carry behavior that doesn't exist in
UpdateVersion. The actual loop increments at positioni, resets to 0 and moves toi-1on overflow, then breaks on the next non-overflowing increment — no position ever gets incremented twice.Changes
UpdateVersion_MaxLastPart_RollsOverCascades: Replaced misleading "incremented TWICE" explanation with accurate per-iteration traceUpdateVersion_MaxThirdPart_RollsOverCascades: Corrected claim thati=1increments from 1→2; it increments from 0→1 and breaksUpdateVersion_MultipleRollovers_HandlesCorrectly: Removed "loop continues and third gets incremented again" narrative; replaced with accurate step-by-step trace and dropped the incorrect inlineAssertcommentBefore → After (example)
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.