Review/michael panic openssl 3#1
Draft
wtoorop wants to merge 68 commits into
Draft
Conversation
Why: * Compiling a .o file alone will compile with "-c file.c" * Compiling a .lo file alone will create the corresponding .o files with "-c ./file.c" * Building with "make -j1" will only execute the .lo rules; the .o rules will be skipped since the .o files are already created from the .lo rules with option "-c ./file.c" * Building with "make -j2" will execute the .lo rules and the .o rules in parallel with option "-c file.c" * assert() captures the path of the source file (taken from the -c option) in the compiled binary in order to display the source of the assertion error * Hence the compiled binaries are not reproducible depending on the number of make parallel jobs Example: * when compiling examples/ldns-dane with "make -j1", the binary contains the string "./examples/ldns-dane.c" * when compiling examples/ldns-dane with "make -j2", the binary contains the string "examples/ldns-dane.c"
Most of the time, in most systems the openSSL RNG seeds itself automatically, in that case rand status returns 1, this is sufficient to return early.
…ve comparison of owner names
Swig has changed language specific AppendOutput functions. But helper macro SWIG_AppendOutput remains unchanged. Use that everywhere instead of SWIG_Python_AppendOutput, which would require one extra parameter since swig 4.3.0. https://github.com/swig/swig/blob/v4.3.0/CHANGES.current#L376 swig/swig#2905
Note that zone output may also be NSEC3 hashed, not just NSEC hashed. Refer to the SEP bit rather than the KSK bit as there is no KSK bit in a DNSKEY.
As reported by CI
Because they don't run anymore
Fixes issue #266.
This is an api change, so we bump version to ldns-1.9.0
builds (make -j).
instead of passing by when one RRSIG validates. That prints output for spurious RRSIGs, the failures for them.
Updates to ldns_is_rrset() Thanks @tgreenx ! Looks good to me!
Features/additional rr types Thanks for the review @wcawijngaard
* PR #286: Fix RR Type AMTRELAY type nogateway, to print relay '.', and memory leaks in parsing it.
Fix RR Type AMTRELAY type nogateway
No long draft-ietf-dnsop-generalized-notify
All the bits and pieces from IANA's DNS Parameters page Plus updated Extended DNS Errors
…riguez-rand_fixes_1
…ldns into InfrastructureServices-develop-swig-4.3
…o duthils-reproducible-build-path
This reverts commit 22a8906.
Thanks gjherbiet
…l-Panic-openssl-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes and updates that came out of review