Remove cifs_common, move functions into cifs_mount & cifs_umount#138
Open
davewongillies wants to merge 1 commit into
Open
Remove cifs_common, move functions into cifs_mount & cifs_umount#138davewongillies wants to merge 1 commit into
davewongillies wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed
cifs_common.shand moved the two functions from it intocifs_mount.shandcifs_umount.shas there's currently no mechanism to ensure that MiSTers havecifs_common.shwithout people knowing about it and there's a bunch of documentation around that tells people to just downloadcifs_mount.sh.So any new users who download
cifs_mount.shorcifs_umount.shwill get errors about the script not working.This change brings thing back to just needing cifs_mount.sh (and optionally cifs_umount.sh)