Update Update-ProjectVersionNumber.ps1 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the same source for multiple builds the current script always updates the variables on the first build, not on the current build. This update sets the build version per build independently.
mattcorr
reviewed
Jun 12, 2019
|
|
||
| # Find the build definition for this project | ||
| $buildDef = $buildDefs.value | Where-Object { $_.Project.id -eq $ProjectId } | ||
| $buildDef = $buildDefs.value | Where-Object { $_.Project.id -eq $ProjectId -and ($_.name -eq $buildName } |
Contributor
There was a problem hiding this comment.
This looks like there is no matching bracket for the one just before $_.name. I would suggest removing that, and the PR will be approved.
Contributor
|
Thanks for your PR! I have reviewed and have a comment about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the same source for multiple builds the current script always updates the variables on the first build, not on the current build. This update sets the build version per build independently.