automate observatory previews #5000
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
🚀 Preview deployment is ready! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35ecd97a33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Configure EKS | ||
| if: github.ref == 'refs/heads/main' | ||
| if: github.ref == 'refs/heads/main' || (env.BUILD_PREVIEW == 'true' && inputs.preview_helm_values != '') |
There was a problem hiding this comment.
When a PR is closed, DELETE_PREVIEW becomes true and the helm delete step runs, but this Configure EKS step only runs for main or BUILD_PREVIEW (open PRs). On a pull_request: closed event, the kubeconfig/context is never set up, so the delete will fail and leave preview releases behind. Consider including the delete path (e.g., env.DELETE_PREVIEW == 'true') in the EKS configure condition or skipping deletion without config.
Useful? React with 👍 / 👎.
| release: observatory | ||
| chart: ./devops/charts/observatory | ||
| preview_helm_values: "--set host=${{ (github.event_name == 'pull_request' && github.event.action != 'closed') && format('observatory-preview-{0}.softmax-research.net', github.event.pull_request.number) || '' }}" | ||
| preview_host: "${{ (github.event_name == 'pull_request' && github.event.action != 'closed') && format('observatory-preview-{0}.softmax-research.net', github.event.pull_request.number) || '' }}" |
There was a problem hiding this comment.
This has to be explicit:
- I want _build-and-deploy workflow to be reusable for charts that don't have host in values.yaml (they might have zero hosts or multiple)
- reusable vars are not easy in github workflows (requires adding another job, with its implied overhead, not worth it)
Ported code from softmax.com.