Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Jan 23, 2026

Summary

  • Add secrets: inherit to the publish-coverage job in the main workflow

Problem

The publish-gh-pages.yml reusable workflow fails with "not found deploy key or tokens" even though PUBLISH_PAGES_TOKEN exists as an environment secret in the github-pages environment.

Root Cause

The reusable workflow needs secrets: inherit from the caller to access environment secrets. Without it, the secrets context in the reusable workflow is empty.

Solution

Add secrets: inherit to the caller in main.yml so the reusable workflow can access the environment secrets.

🤖 Generated with Claude Code


Note

Ensures the reusable publish-gh-pages.yml can access environment secrets when publishing coverage.

  • Adds secrets: inherit to the publish-coverage job in .github/workflows/main.yml so coverage can be deployed to GitHub Pages on main pushes

Written by Cursor Bugbot for commit c41f74d. This will update automatically on new commits. Configure here.

The publish-coverage job calls the publish-gh-pages reusable workflow
which requires PUBLISH_PAGES_TOKEN from the github-pages environment.
Without secrets: inherit, the secrets context in reusable workflows is
empty, even when an environment is declared at the job level.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rekmarks rekmarks requested a review from a team as a code owner January 23, 2026 18:25
@rekmarks rekmarks enabled auto-merge January 23, 2026 18:29
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.22%
⬇️ -0.15%
5702 / 6463
🔵 Statements 88.1%
⬇️ -0.14%
5794 / 6576
🔵 Functions 87.19%
⬇️ -0.31%
1484 / 1702
🔵 Branches 84.52%
⬆️ +0.09%
2059 / 2436
File CoverageNo changed files found.
Generated in workflow #3309 for commit c41f74d by the Vitest Coverage Report Action

Copy link
Contributor

@grypez grypez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't inherit all repo secrets, just the gh pages ones.

@rekmarks rekmarks added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 3495055 Jan 23, 2026
30 checks passed
@rekmarks rekmarks deleted the rekm/fix-coverage-2 branch January 23, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants