-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: display a warning when gas sponsorship failed #39284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Julink-eth
wants to merge
4
commits into
main
Choose a base branch
from
feat/display-gas-sponsorship-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+257
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (3 files, +249 -0)
|
ui/pages/confirmations/hooks/alerts/transactions/useGasSponsorshipWarningAlerts.test.ts
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/hooks/alerts/transactions/useGasSponsorshipWarningAlerts.test.ts
Show resolved
Hide resolved
Contributor
Builds ready [513723d]
UI Startup Metrics (1269 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Gas sponsorship on certain networks (like Monad) has reserve balance requirements. When a transaction simulation fails due to reserve balance violations, users currently don't receive clear feedback about why sponsorship isn't available.
Problem
Users on networks with gas sponsorship reserve requirements (e.g., Monad requires 10 MON minimum) don't see any warning when their transaction can't be sponsored due to insufficient reserve balance.
Solution
Added a new useGasSponsorshipWarningAlerts hook that:
Checks simulationData.callTraceErrors for known sponsorship failure patterns
Uses a configurable rules system (GAS_SPONSORSHIP_WARNING_RULES) to match chain-specific error patterns
Displays a Severity.Warning alert on the EstimatedFee row when sponsorship fails due to reserve balance violations
Currently configured for Monad (10 MON minimum reserve requirement)
Related Core PR : MetaMask/core#7641
Changelog
CHANGELOG entry: Added a warning message when gas sponsorship is unavailable due to reserve balance requirements.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a new warning surfaced in transaction confirmations when sponsorship is unavailable based on simulation call trace errors.
useGasSponsorshipWarningAlertscheckssimulationData.callTraceErrorsandnetworkConfigurationsByChainIdto show aSeverity.WarningonEstimatedFee(currently forMONADwith 10nativeCurrencyminimum)useConfirmationAlertsso it appears with other transaction alertsgasSponsorshipReserveBalanceWarninginenanden_GBuseGasSponsorshipWarningAlertsvalidate no-op cases and the Monad reserve balance warningWritten by Cursor Bugbot for commit 513723d. This will update automatically on new commits. Configure here.