feat: use dynamic supported networks from Price API #7716
Merged
+549
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
juanmigdr
reviewed
Jan 26, 2026
| // This ensures the list stays fresh during normal polling | ||
| // Note: fetchSupportedNetworks handles errors internally and always resolves | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| fetchSupportedNetworks(); |
Member
There was a problem hiding this comment.
I dont understand why we are calling the fetchSupportedNetworks function here. That function is not storing anything in state so why would we need to call it here if we are not making use of the response at all
Contributor
Author
There was a problem hiding this comment.
fetchSupportedNetworks() updates a module-level cache (lastFetchedSupportedNetworks). The background call keeps this cache fresh so that subsequent calls to getSupportedChainIdsV3AsHex() return up-to-date data.
This is the same pattern used for fetchSupportedCurrencies() in fetchExchangeRates().
Member
There was a problem hiding this comment.
Oh missed that, thanks! Why did you change it to be blocking instead of non-blocking now?
Kriys94
reviewed
Jan 26, 2026
| * | ||
| * @returns The supported networks response. | ||
| */ | ||
| export async function fetchSupportedNetworks(): Promise<SupportedNetworksResponse> { |
Contributor
There was a problem hiding this comment.
You could find the call in core-backend
packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Outdated
Show resolved
Hide resolved
packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Outdated
Show resolved
Hide resolved
salimtb
force-pushed
the
feat/dynamic-supported-networks-price-api
branch
from
4324802 to
863782e
Compare
Contributor
There was a problem hiding this comment.
Should we finally rename codefi-v2 😄
We can do this later.
Prithpal-Sooriya
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Current State
The
CodefiTokenPricesServiceV2inassets-controllersuses a hardcoded list (SPOT_PRICES_SUPPORT_INFO) to determine which blockchain networks are supported by the Price API's/v3/spot-pricesendpoint. This approach has several drawbacks:Additionally, the native asset CAIP-19 identifiers (e.g.,
eip155:1/slip44:60for ETH) were also hardcoded, duplicating data that already exists inNetworkEnablementController.state.nativeAssetIdentifiers.Solution
This PR introduces dynamic fetching of supported networks from the Price API's
/v2/supportedNetworksendpoint:fetchSupportedNetworks()function that fetches from/v2/supportedNetworksand caches the responsefetchTokenPrices()callsetNativeAssetIdentifiers()method to receive native asset mappings fromNetworkEnablementController, eliminating duplicationnativeAssetIdentifiersfromNetworkEnablementControllerto the token prices serviceChanges Summary
codefi-v2.ts: Added dynamic network fetching, caching, and native asset identifier supportabstract-token-prices-service.ts: AddedNativeAssetIdentifiersMaptype and optionalsetNativeAssetIdentifiers()method to interfaceTokenRatesController.ts: Integrated withNetworkEnablementControllerto pass native asset identifiers@metamask/network-enablement-controlleras a dependencyReferences
https://price.api.cx.metamask.io/v2/supportedNetworksNetworkEnablementController.state.nativeAssetIdentifiersfor CAIP-19 native token mappingsChecklist
Note
Introduces dynamic network support and native asset identifier integration for token pricing.
fetchSupportedNetworks(),getSupportedNetworks(), andresetSupportedNetworksCache()in token-prices-service (fallback to hardcoded list; background refresh duringfetchTokenPrices)CodefiTokenPricesServiceV2to:setNativeAssetIdentifiers()and use CAIP-19 IDs for native tokensupdateSupportedNetworks()TokenRatesControllernow callsNetworkEnablementController:getStateat init to passnativeAssetIdentifiersto the token prices serviceNativeAssetIdentifiersMap; add@metamask/network-enablement-controllerdependency and TS references; expand tests for new behaviorWritten by Cursor Bugbot for commit 863782e. This will update automatically on new commits. Configure here.