feat(bridge-status): add polling for Tron same-chain swaps #7697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tron swaps use async settlement and need polling to get the destination tx hash. This is used to filter duplicate receive transactions in the activity list.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/bridge-status-controller/src/bridge-status-controller.ts
Outdated
Show resolved
Hide resolved
packages/bridge-status-controller/src/bridge-status-controller.ts
Outdated
Show resolved
Hide resolved
7 tasks
micaelae
reviewed
Jan 23, 2026
Comment on lines
+519
to
+521
| // Tron same-chain swaps use async settlement and need polling | ||
| const isTronSameChainSwap = | ||
| !isBridgeTx && !isIntent && isTronChainId(historyItem.quote.srcChainId); |
Member
There was a problem hiding this comment.
Polling needs to be done for Tron bridge txs too so this should just check for isTronChainId
micaelae
reviewed
Jan 23, 2026
| this.#startPollingForTxId(txMeta.id); | ||
| // Track non-EVM Swap completed event | ||
| if (!isBridgeTx) { | ||
| if (!isBridgeTx && !isTronSameChainSwap) { |
Member
There was a problem hiding this comment.
Same here - both swaps and bridges will be polled so the Completed event can't be published until we get a txStatus
Suggested change
| if (!isBridgeTx && !isTronSameChainSwap) { | |
| if (!(isBridgeTx || isTronTx)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tron swaps use async settlement and need polling to get the destination tx hash. This is used to filter duplicate receive transactions in the activity list.
Explanation
References
Related to: MetaMask/metamask-extension#39446, fixes a bug where async tron swaps are rendered as receives/sends in the activity list.
Checklist
Note
Enables async settlement handling for Tron same-chain swaps by starting status polling and refining when polling is (re)started.
#shouldPollHistoryItemto centralize polling decisions (polls forbridge,intent, and Tron same-chain swaps) and uses it in resume/restart polling pathssubmitTx, detectsisTronSameChainSwap, starts polling for non-EVM, and avoids immediateCompletedtracking for Tron same-chain swaps (will complete via polling)isTronChainIdfrombridge-controllerfor use in status controllerWritten by Cursor Bugbot for commit 1da7003. This will update automatically on new commits. Configure here.