Skip to content

Lift adjustable psyclone command options into adjustable flag Transmute #246

Open
MetBenjaminWent wants to merge 3 commits intoMetOffice:mainfrom
MetBenjaminWent:psyclone_transmute_flags_override
Open

Lift adjustable psyclone command options into adjustable flag Transmute #246
MetBenjaminWent wants to merge 3 commits intoMetOffice:mainfrom
MetBenjaminWent:psyclone_transmute_flags_override

Conversation

@MetBenjaminWent
Copy link
Contributor

@MetBenjaminWent MetBenjaminWent commented Feb 11, 2026

PR Summary

For transmute command makefile.
This issue MetOffice/simulation-systems#574 has requested the ability to adjust the line length for the Transmute command due to compiler issues at their site.
We have agreed to also modify the PSyKAl command in the same way.
-l all seems to be the only option that should be overridable.
Users should be able to use this variable, but privatised for a file by file basis, though this has not yet been explored.

Twin but not linked Core change PR: MetOffice/lfric_core#271

Sci/Tech Reviewer: @mo-alistairp
Code Reviewer: @harry-shepherd

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - psyclone_transmute_flags_override/run1

Suite Information

Item Value
Suite Name psyclone_transmute_flags_override/run1
Suite User benjamin.went
Workflow Start 2026-02-11T14:43:36
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2025.12.1 True
jules MetOffice/jules@69aaf4d True
lfric_apps MetBenjaminWent/lfric_apps@psyclone_transmute_flags_override False
lfric_core MetBenjaminWent/lfric_core@1b8de6a True
moci MetOffice/moci@2025.12.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True
socrates MetOffice/socrates@2025.12.1 True
socrates-spectral MetOffice/socrates-spectral@2025.12.1 True
ukca MetOffice/ukca@2025.12.1 True

Task Information

❌ failed tasks - 1
Task State
run_jules_dice2-BiP2x2-50000x50000_azspice_gnu_fast-debug-64bit failed
  • Unrelated to changes, seems to be timeouts
✅ succeeded tasks - 1107

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@MetBenjaminWent
Copy link
Contributor Author

In the short term, users should be able to override PSYCLONE_TRANSMUTE_EXTRAS in their site specific cylc file, in the build step:
https://github.com/MetOffice/lfric_apps/blob/main/rose-stem/site/nci/common/suite_config_gadi.cylc

Copy link
Contributor

@mo-alistairp mo-alistairp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the change functionally. One minor request - could you correct psyclone to PSyclone, once in each file?

@MetBenjaminWent
Copy link
Contributor Author

Comments are updated as per SR request

Copy link
Contributor

@mo-alistairp mo-alistairp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change. Happy to approve

@MetBenjaminWent
Copy link
Contributor Author

Docs updated here: #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants