Lift adjustable psyclone command options into adjustable flag Transmute #246
Open
MetBenjaminWent wants to merge 3 commits intoMetOffice:mainfrom
Open
Lift adjustable psyclone command options into adjustable flag Transmute #246MetBenjaminWent wants to merge 3 commits intoMetOffice:mainfrom
MetBenjaminWent wants to merge 3 commits intoMetOffice:mainfrom
Conversation
29 tasks
Contributor
Author
|
In the short term, users should be able to override |
mo-alistairp
requested changes
Feb 12, 2026
Contributor
mo-alistairp
left a comment
There was a problem hiding this comment.
Happy with the change functionally. One minor request - could you correct psyclone to PSyclone, once in each file?
Contributor
Author
|
Comments are updated as per SR request |
mo-alistairp
approved these changes
Feb 12, 2026
Contributor
mo-alistairp
left a comment
There was a problem hiding this comment.
Thanks for making that change. Happy to approve
This was referenced Feb 12, 2026
Contributor
Author
|
Docs updated here: #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
For transmute command makefile.
This issue MetOffice/simulation-systems#574 has requested the ability to adjust the line length for the Transmute command due to compiler issues at their site.
We have agreed to also modify the PSyKAl command in the same way.
-l all seems to be the only option that should be overridable.
Users should be able to use this variable, but privatised for a file by file basis, though this has not yet been explored.
Twin but not linked Core change PR: MetOffice/lfric_core#271
Sci/Tech Reviewer: @mo-alistairp
Code Reviewer: @harry-shepherd
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - psyclone_transmute_flags_override/run1
Suite Information
Task Information
❌ failed tasks - 1
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review