Skip to content

Fix fetching data for validity time#1911

Merged
jfrost-mo merged 1 commit intomainfrom
1898_fix_validity_time_data_fetching
Feb 17, 2026
Merged

Fix fetching data for validity time#1911
jfrost-mo merged 1 commit intomainfrom
1898_fix_validity_time_data_fetching

Conversation

@daflack
Copy link
Collaborator

@daflack daflack commented Feb 17, 2026

Updates fetch_data.py and the corresponding test.

Fixes #1898

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@daflack daflack added this to the CSET v26.2.0 milestone Feb 17, 2026
@daflack daflack requested a review from jfrost-mo February 17, 2026 11:20
@daflack daflack self-assigned this Feb 17, 2026
@daflack daflack added bug Something isn't working small Small issue that should be quick to resolve labels Feb 17, 2026
@github-actions
Copy link
Contributor

Coverage

Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Time and bounds are both so confusing...

@jfrost-mo jfrost-mo merged commit d77cb8a into main Feb 17, 2026
8 checks passed
@jfrost-mo jfrost-mo deleted the 1898_fix_validity_time_data_fetching branch February 17, 2026 12:55
@jfrost-mo jfrost-mo changed the title Fixes fetching data for validity time Fix fetching data for validity time Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working small Small issue that should be quick to resolve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetching data on validity time misses the last file

2 participants