Add native MTP ngram hybrid proposer#875
Draft
i386 wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
SKIPPY_NATIVE_MTP_NGRAM_HYBRID=1is enabled.Fresh Lab Benchmark
Dataset:
nvidia/SPEED-Bench,qualitative,coding,reasoning,LIMIT=4per category,OSL=512, 8 requests / 9 turns per condition. Golden target is vanilla llama.cpp no-MTP.Important lab note: studio54 direct reads from
/Volumes/External/.../GLM-4.7-Flash-MTP-Q4_K_M.ggufwere hanging during this run. I materialized the same GGUF to/Users/jdumay/tmp/skippy-models/GLM-4.7-Flash-MTP-Q4_K_M.gguffor stage0/vanilla. micstudio stage1 used the existing NFS path successfully.ngram_size=4,max=2ngram_size=4,max=4ngram_size=4,max=8ngram_size=8,max=4ngram_size=16,max=4Winning row:
SKIPPY_NATIVE_MTP_NGRAM_HYBRID=1 SKIPPY_NATIVE_MTP_NGRAM_SIZE=4 SKIPPY_NATIVE_MTP_NGRAM_MAX_PROPOSAL_TOKENS=4.Observations:
max=8widened proposals further, but its lower tail acceptance and higher stage1 compute left it slightly behindmax=4.Artifacts:
/Users/jdumay/code/lab-experiments/jianyang/benchmarks/speed-bench/results/pr875-vanilla-internal-fitoff-hfcache-20260618T102050Z/Users/jdumay/code/lab-experiments/jianyang/benchmarks/speed-bench/results/pr875-skippy-split-hybrid-static-20260618T102746Z/Users/jdumay/code/lab-experiments/jianyang/benchmarks/speed-bench/results/pr875-skippy-split-hybrid-max-sweep-20260618T104146ZValidation
cargo check -p skippy-servercargo check -p skippy-promptcargo test -p skippy-server --libcargo test -p skippy-promptcargo fmt --all --checkcargo clippy -p skippy-server --all-targets -- -D warningscargo clippy -p skippy-prompt --all-targets -- -D warningsskippy-serveron studio54 + micstudio