Fix multi-shard moe-split tensor counting#4
Merged
Conversation
4f91049 to
6cd1324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
llama-moe-spliton the currentmasterbranch.Users building Mesh-LLM's forked
llama.cppcan now compile the MoE split tool again instead of failing with an undeclaredn_tensorserror in the multi-shard write path.Root Cause
write_group()was updated to operate oninput_shards, but the context-size calculation still referenced a singlen_tensorsvariable from the older single-input implementation.That made the current multi-shard path fail to compile on
master.Change
gguf_get_n_tensors(...)across allinput_shardsValidation
cmake --build build --target llama-moe-split -j4