Improved trade UI by displaying market value breakdown per item#873
Open
NAIRBS wants to merge 5 commits intoMephiles:masterfrom
Open
Improved trade UI by displaying market value breakdown per item#873NAIRBS wants to merge 5 commits intoMephiles:masterfrom
NAIRBS wants to merge 5 commits intoMephiles:masterfrom
Conversation
Better item display tabulation in Trade item value tabulation
CSS changes to mimic item tabulation
Update ttTradeValues.css
Collaborator
|
Nothing against the change itself, but not a fan of it shifting the UI more than it already could. So I would prefer an option for this to be disabled, but it can be enabled by default. |
Collaborator
|
Additionally, some stuff missing for the changelog.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current trade interface only displays the total value of items, which makes it difficult to verify the individual unit price, especially when comparing them against receipts issued by traders on Torn Exchange.
This update enhances the trade window by appending a market value breakdown next to each item, similar to how item market values are shown in the torn inventory.
For example, an item now for example displays:
$12,000 | 4x = $48,000
I’ve also tested with inflated item values (e.g., Small First Aid Kit) to ensure the formatting works with large numbers and longer text.
Do note that I do not have a complete understanding of what TornTools has to consider such as individual user settings or other considerations like mobile or pc layouts if that is applicable, so my code might need further review.
Additionally, I might have left some remnants of the previous code commented out or left unused in the .css file.
It should be removed if considered unnecessary.
Images showcasing this new cosmetic feature:
Before:
After: