Skip to content

Improved trade UI by displaying market value breakdown per item#873

Open
NAIRBS wants to merge 5 commits intoMephiles:masterfrom
NAIRBS:master
Open

Improved trade UI by displaying market value breakdown per item#873
NAIRBS wants to merge 5 commits intoMephiles:masterfrom
NAIRBS:master

Conversation

@NAIRBS
Copy link

@NAIRBS NAIRBS commented Jul 4, 2025

The current trade interface only displays the total value of items, which makes it difficult to verify the individual unit price, especially when comparing them against receipts issued by traders on Torn Exchange.

This update enhances the trade window by appending a market value breakdown next to each item, similar to how item market values are shown in the torn inventory.

For example, an item now for example displays:
$12,000 | 4x = $48,000

I’ve also tested with inflated item values (e.g., Small First Aid Kit) to ensure the formatting works with large numbers and longer text.

Do note that I do not have a complete understanding of what TornTools has to consider such as individual user settings or other considerations like mobile or pc layouts if that is applicable, so my code might need further review.

Additionally, I might have left some remnants of the previous code commented out or left unused in the .css file.
It should be removed if considered unnecessary.

Images showcasing this new cosmetic feature:

Before:

chrome_lDDMtnBgb7

After:

Photos_ID2NwkBvDG

NAIRBS added 5 commits July 4, 2025 17:49
Better item display tabulation in Trade item value tabulation
CSS changes to mimic item tabulation
Update ttTradeValues.css
@DeKleineKobini
Copy link
Collaborator

Nothing against the change itself, but not a fan of it shifting the UI more than it already could. So I would prefer an option for this to be disabled, but it can be enabled by default.

@DeKleineKobini
Copy link
Collaborator

Additionally, some stuff missing for the changelog.

Any changes should be added in the extension/changelog.json file under the first unreleased version.
First contributions should also update extension/ scripts/global/team.js to add yourself as member and choose a color for in the changelog.

CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants