Skip to content

Conversation

@ajayi-joseph
Copy link
Contributor

Description

This PR implements real integration tests for the dart_node_ws package, replacing the previous TODO. The new tests verify actual client-server WebSocket communication using Node.js ws for the client via JS interop. All tests pass, and the implementation follows project guidelines (typed APIs, no duplication, Result<T,E> usage, and no global state).

  • Adds 3 new integration tests to ws_test.dart (total: 14 tests)
  • Removes obsolete websocket_test.dart (if present)
  • Ensures only ws_test.dart is used for WebSocket tests
  • All tests pass locally

Checklist

  • Integration tests implemented and passing
  • No duplicate or obsolete test files
  • Follows project code and testing rules
  • Clean commit history

@MelbourneDeveloper
Copy link
Owner

Hey thanks @ajayi-joseph

This one needs a dart format . in the ws package

image

@ajayi-joseph
Copy link
Contributor Author

ajayi-joseph commented Jan 27, 2026

Yeah. I'll fix that now. This is a 1 of 3 PRs for websocket.

@ajayi-joseph
Copy link
Contributor Author

@MelbourneDeveloper .. Should be ready for review/merge shortly

@MelbourneDeveloper
Copy link
Owner

Thankyou @ajayi-joseph

@MelbourneDeveloper MelbourneDeveloper merged commit fc95acf into MelbourneDeveloper:main Jan 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants