Skip to content

Workflow Orchestrator -> Plugin Env Support#361

Merged
hjmeesho merged 1 commit intodevelopfrom
feat/WO-activity-contracts-v2
Apr 1, 2026
Merged

Workflow Orchestrator -> Plugin Env Support#361
hjmeesho merged 1 commit intodevelopfrom
feat/WO-activity-contracts-v2

Conversation

@hjmeesho
Copy link
Copy Markdown
Contributor

@hjmeesho hjmeesho commented Apr 1, 2026

🔁 Pull Request Template – BharatMLStack

Please fill out the following sections to help us review your changes efficiently.

Context:

Give a brief overview of the motivation behind this change. Include any relevant discussion links (Slack, documents, tickets, etc.) that help reviewers understand the background and the issue being addressed.

Describe your changes:

Mention the changes made in the codebase.

Testing:

Please describe how you tested the code. If manual tests were performed - please explain how. If automatic tests were added or existing ones cover the change - please explain how did you run them.

Monitoring:

Explain how this change will be tracked after deployment. Indicate whether current dashboards, alerts, and logs are enough, or if additional instrumentation is required.

Rollback plan

Explain rollback plan in case of issues.

Checklist before requesting a review

  • I have reviewed my own changes?
  • Relevant or critical functionality is covered by tests?
  • Monitoring needs have been evaluated?
  • Any necessary documentation updates have been considered?

📂 Modules Affected

  • horizon (Real-time systems / networking)
  • online-feature-store (Feature serving infra)
  • trufflebox-ui (Admin panel / UI)
  • infra (Docker, CI/CD, GCP/AWS setup)
  • docs (Documentation updates)
  • Other: ___________

✅ Type of Change

  • Feature addition
  • Bug fix
  • Infra / build system change
  • Performance improvement
  • Refactor
  • Documentation
  • Other: ___________

📊 Benchmark / Metrics (if applicable)

Summary by CodeRabbit

  • New Features
    • Activity input contract now supports optional configuration parameters, enabling dynamic runtime configuration injection for plugins.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fcd97950-3b94-42c5-874d-f4b67ef46dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 4cf17af and 676e4e2.

📒 Files selected for processing (1)
  • core/activity-contracts/activity/activity.go

Walkthrough

The ActivityInput struct in the activity contract is extended with an optional Config field of type map[string]string. This allows plugin configuration to be injected at runtime when activities are invoked, while maintaining backward compatibility with existing activity implementations.

Changes

Cohort / File(s) Summary
Activity Input Contract
core/activity-contracts/activity/activity.go
Added optional Config field to ActivityInput struct to support runtime injection of plugin configuration.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Dynamic Configuration Validation ✅ Passed The custom check explicitly states to PASS if there are no changes to application-dyn-.yml file. This PR contains no changes to any application-dyn-.yml files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@hjmeesho hjmeesho merged commit aafb59f into develop Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants