Skip to content

updated projects to dotnet9 + switched to incremental source generator#1

Merged
MaximTkachenko merged 7 commits into
mainfrom
feat/dotnet9-with-incremental-sg
Oct 13, 2025
Merged

updated projects to dotnet9 + switched to incremental source generator#1
MaximTkachenko merged 7 commits into
mainfrom
feat/dotnet9-with-incremental-sg

Conversation

@MaximTkachenko

Copy link
Copy Markdown
Owner

No description provided.

@MaximTkachenko

MaximTkachenko commented Oct 5, 2025

Copy link
Copy Markdown
Owner Author
  • fix warnings
  • improve the code quality
  • start benchmarks again

@MaximTkachenko MaximTkachenko requested a review from Copilot October 5, 2025 18:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the solution to target .NET 9 and migrates the source generator from the classic ISourceGenerator model to an incremental IIncrementalGenerator while updating Roslyn and test/benchmark dependencies.

  • Upgrade target frameworks (net5.0 -> net9.0) and dependency versions across projects
  • Introduce incremental source generator pipeline and supporting launchSettings for debugging
  • Adjust tests to instantiate the generated parser directly

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/Parsers.Tests.csproj Upgrades test project to .NET 9 and updates test dependencies.
test/ParserGeneratorTests.cs Replaces reflective instantiation with direct construction of generated parser.
src/Parsers/Parsers.csproj Upgrades runtime parser project framework and Roslyn dependency.
src/Parsers.SourceGenerator/Properties/launchSettings.json Adds launch profile for debugging the source generator.
src/Parsers.SourceGenerator/Parsers.SourceGenerator.csproj Updates analyzer/compiler packages and enables incremental generator-related build properties.
src/Parsers.SourceGenerator/ParserSourceGenerator.cs Reimplements generator as an incremental generator and refactors symbol discovery logic.
benchmark/Parsers.Benchmarks.csproj Upgrades benchmark project to .NET 9 and newer BenchmarkDotNet.
.github/workflows/dotnet.yml CI updated to use .NET 9 SDK.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/Parsers.SourceGenerator/Properties/launchSettings.json
Comment thread src/Parsers.SourceGenerator/ParserSourceGenerator.cs Outdated
Comment thread src/Parsers.SourceGenerator/ParserSourceGenerator.cs Outdated
Comment thread src/Parsers.SourceGenerator/ParserSourceGenerator.cs Outdated
@MaximTkachenko MaximTkachenko merged commit 67856cf into main Oct 13, 2025
1 check passed
@MaximTkachenko MaximTkachenko deleted the feat/dotnet9-with-incremental-sg branch October 13, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants