added a script to modify customizable values#7
added a script to modify customizable values#7akabul0us wants to merge 1 commit intoMatheuZSecurity:mainfrom
Conversation
|
IMO its better to add |
|
That would be a bit neater, rather than the current approach of having the values scattered across several files. This script would become simpler, too, as there'd be no need to make $file a variable. |
I don't think you'd need a script if all configurables are in the single place.
No, just a drive-by suggestion :) |
That's the secret of shell scripts: nobody needs them, really 😁 |
|
This pull request has been open for a month and I only just now realized that you're not the repo maintainer, so I kind of doubt either of our suggestions find their way into the code |
|
Here is something similar to what I use for CompileasaService #!/bin/bash sed -i "s|#define YOUR_SRV_IP "."|#define YOUR_SRV_IP "$YOUR_SRV_IP"|" "$BUILD_ROOT/include/core.h" |
A bit easier than manually editing all of the files and values from the README. I'll likely add some more features later (like recording changed values and resetting them as the new defaults) but as it is now this works just fine.