adapter: improve error on invalid subscribe bounds #34671
Merged
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
improve-subscribe-error
branch
from
5c57de3 to
d5356c9
Compare
antiguru
approved these changes
Jan 9, 2026
teskje
force-pushed
the
improve-subscribe-error
branch
from
d5356c9 to
ca1cadf
Compare
This commit makes clearer the error message emitted in response to a SUBSCRIBE command whose AS OF is greater than its UP TO. Most significantly it flips the order of the terms in the inequality to be consistent with the preceding error text.
teskje
force-pushed
the
improve-subscribe-error
branch
from
ca1cadf to
2fbd170
Compare
Contributor
Author
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes clearer the error message emitted in response to a SUBSCRIBE command whose AS OF is greater than its UP TO. Most significantly it flips the order of the terms in the inequality to be consistent with the preceding error text.
Motivation
See Slack thread.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.