Skip to content

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Jan 8, 2026

When applying a replacement materialized view, in the process of which we drop the replacement, we need to also drop any comments that exist for the replacement.

Motivation

  • This PR adds a known-desirable feature.

Part of https://github.com/MaterializeInc/database-issues/issues/9903

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje teskje force-pushed the replacement-mv-comments branch from c5e89e0 to ec0331e Compare January 8, 2026 12:52
@teskje teskje marked this pull request as ready for review January 8, 2026 12:54
@teskje teskje requested a review from a team as a code owner January 8, 2026 12:54
@teskje teskje requested a review from ggevay January 8, 2026 12:54
@teskje teskje force-pushed the replacement-mv-comments branch from ec0331e to 7ece208 Compare January 8, 2026 13:00
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the test issue.

When applying a replacement materialized view, in the process of which
we drop the replacement, we need to also drop any comments that exist
for the replacement.
@teskje teskje force-pushed the replacement-mv-comments branch from 7ece208 to b4417f8 Compare January 8, 2026 15:42
@teskje
Copy link
Contributor Author

teskje commented Jan 8, 2026

TFTR!

@teskje teskje merged commit e3adb21 into MaterializeInc:main Jan 8, 2026
132 checks passed
@teskje teskje deleted the replacement-mv-comments branch January 8, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants