Skip to content

chore: simplify development setup#751

Merged
petermasking merged 4 commits intomainfrom
750-simplify-development-setup
Feb 13, 2026
Merged

chore: simplify development setup#751
petermasking merged 4 commits intomainfrom
750-simplify-development-setup

Conversation

@basmasking
Copy link
Member

Fixes #750

Changes proposed in this pull request:

  • removed workflows that are not needed
  • removed sonar from linting, it runs in sonarcloud
  • fixed minor issues and documentation (boyscout)

@MaskingTechnology/jitar

@basmasking basmasking linked an issue Feb 13, 2026 that may be closed by this pull request
@petermasking petermasking merged commit d24c0cc into main Feb 13, 2026
22 checks passed
@petermasking petermasking deleted the 750-simplify-development-setup branch February 13, 2026 14:24
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • New Features

    • Improved startup and shutdown sequence for better performance.
  • Bug Fixes

    • Corrected documentation titles across multiple packages.
    • Updated deprecated package notice for create-jitar.
  • Chores

    • Updated dependencies: TypeScript ESLint and Turbo.
    • Removed unused sonarjs linting plugin.
    • Modernized Node.js module imports.

Walkthrough

This PR consolidates development tooling by updating GitHub workflows to use pull request triggers, removing the sonarjs ESLint plugin, updating dependencies, modernizing Node module imports to use node: specifiers, changing LocalGateway startup/shutdown from parallel to sequential execution, and updating package README titles for clarity.

Changes

Cohort / File(s) Summary
GitHub Workflows
.github/workflows/codeql.yml, .github/workflows/nodejsci.yml
Migrated triggers from push to pull_request, reformatted schedule indentation, and refactored Node.js setup step using actions/setup-node@v6 with matrix node-version.
ESLint & Dependencies
eslint.config.mjs, package.json
Removed sonarjs plugin import and related rules; updated @typescript-eslint and turbo versions; removed eslint-plugin-sonarjs dependency.
Linting Directives
packages/analysis/src/static/Parser.ts, packages/execution/test/utils/VersionParser.spec.ts
Removed eslint-disable-next-line sonarjs directives from method definitions and test cases.
Package READMEs
packages/create-jitar/README.md, packages/http/README.md, packages/services/README.md, packages/sourcing/README.md, packages/validation/README.md
Updated README titles to reflect correct package names; create-jitar marked as deprecated with single-line notice.
HTTP Module
packages/http/src/HttpServer.ts, packages/http/test/fixtures/TestHttpClient.ts, packages/http/test/fixtures/httpResponses.fixture.ts
Modernized import from http to node:http; refactored TestHttpClient to return value directly; added explicit Record<string, Response> type annotation to HTTP_RESPONSES constant.
Services Gateway
packages/services/src/gateway/LocalGateway.ts, packages/services/src/gateway/utils/IdGenerator.ts
Changed startup/shutdown flow from parallel to sequential execution; modernized crypto import from crypto to node:crypto.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • petermasking

Poem

🐰 The sonarjs plugin hops away,
Node imports shine in modern day,
Workflows dance in pull request grace,
Sequential startup finds its place,
READMEs sparkle, names now true—
Development simplified anew! ✨

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify development setup

2 participants