chore(deps): pin fastapi/starlette to prevent transparent major intrusion#92
Merged
Conversation
…sion Loose lower bounds (fastapi>=0.136.0, starlette>=1.0.0) let pip transparently resolve the latest release whenever the CI pip cache (keyed on requirements.txt) was invalidated by a dependency bump. The 0.136.3 -> 0.137.1 jump changed how include_router routes appear in app.router.routes (now nested under Mount), silently breaking the route-inventory test (got 7 /api routes, expected >10). Pin to the currently-green versions so future major/minor updates come through explicit Dependabot PRs that run CI, matching the == house style used by uvicorn / python-multipart / pydantic-settings. fastapi==0.137.1 starlette==1.3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
PR #90 マージ後、CI
Build and Test(ubuntu/windows)がtest_route_inventoryで失敗。真因はrequirements.txtの緩い下限(fastapi>=0.136.0/starlette>=1.0.0)で、pipキャッシュ無効化時に最新が透過解決され0.136.3→0.137.1でinclude_routerルートがapp.router.routes上で Mount にネスト化 → ルート列挙テストが沈黙崩壊した(PR #91 でテスト側は再帰列挙に修正済)。変更
再発防止として現在 green の版に exact pin（== house style に統一）:
fastapi==0.137.1starlette==1.3.1以後の major/minor は Dependabot 明示 PR → CI レビュー経由になる。CVE-2024-47874 / CVE-2025-54121(starlette経由)は本版で修正済み。
🤖 Generated with Claude Code