Added support for rhino scripting engine based PAC evaluation#62
Open
bergmannm wants to merge 1 commit intoMarkusBernhardt:masterfrom
Open
Added support for rhino scripting engine based PAC evaluation#62bergmannm wants to merge 1 commit intoMarkusBernhardt:masterfrom
bergmannm wants to merge 1 commit intoMarkusBernhardt:masterfrom
Conversation
Contributor
|
#41 was merged but then Nashorn was dropped from JDK 11. Also, we got a lot of requests that Nashorn is very slow (https://youtrack.jetbrains.com/issue/IDEA-202661, https://youtrack.jetbrains.com/issue/IDEA-203926). So, this PR is wanted to be merged :) |
Contributor
|
As Nashorn is deprecated, I suggest simply revert #41 (I can prepare PR (JetBrains/intellij-deps-proxy-vole@3b9870c)). No need to add ability to use Nashorn as it is deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for optional Rhino scripting engine PAC evaluation. Nashorn is kept as default.