Skip to content
/ server Public
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions extra/mariabackup/backup_copy.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1926,6 +1926,30 @@ copy_back()

rocksdb_copy_back(ds_tmp);

/* MDEV-34713 Create mariadb_upgrade_info file to avoid unnecessary upgrade
prompts after restore */
if (ret) {
char upgrade_info_path[FN_REFLEN];
FILE *upgrade_info_file;

snprintf(upgrade_info_path, sizeof upgrade_info_path,
"%s/mariadb_upgrade_info", mysql_data_home);

upgrade_info_file = fopen(upgrade_info_path, "w");
if (upgrade_info_file) {
if (fprintf(upgrade_info_file, "%s", MYSQL_SERVER_VERSION) < 0 ||
fflush(upgrade_info_file) != 0) {
msg("Warning: Failed to write mariadb_upgrade_info");
} else {
msg("Created mariadb_upgrade_info with version %s",
MYSQL_SERVER_VERSION);
}
fclose(upgrade_info_file);
} else {
msg("Warning: Failed to create mariadb_upgrade_info");
}
}

cleanup:
if (it != NULL) {
datadir_iter_free(it);
Expand Down
4 changes: 4 additions & 0 deletions mysql-test/suite/mariabackup/full_backup.result
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ INSERT INTO t VALUES(2);
SELECT * FROM t;
i
1
#
# MDEV-34713 Check that mariadb_upgrade_info is created during copy-back
#
FOUND 1 /MariaDB/ in mariadb_upgrade_info
DROP TABLE t;
#
# MDEV-27121 mariabackup incompatible with disabled dedicated
Expand Down
10 changes: 10 additions & 0 deletions mysql-test/suite/mariabackup/full_backup.test
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ exec $XTRABACKUP --prepare --target-dir=$targetdir;
--enable_result_log

SELECT * FROM t;

--echo #
--echo # MDEV-34713 Check that mariadb_upgrade_info is created during copy-back
--echo #
let $_datadir= `SELECT @@datadir`;
--file_exists $_datadir/mariadb_upgrade_info
--let SEARCH_FILE=$_datadir/mariadb_upgrade_info
--let SEARCH_PATTERN=MariaDB
--source include/search_pattern_in_file.inc

DROP TABLE t;
rmdir $targetdir;

Expand Down