Code Review 18.04

adapter/.gradle/buildOutputCleanup/cache.properties

@@ -0,0 +1,2 @@
+#Tue Mar 22 23:09:21 CET 2022
+gradle.version=6.7

adapter/Dockerfile

@@ -3,13 +3,6 @@
 #----------------------------------------------------------#
 FROM node:16-alpine as base
 
-# install dependencies for pact (https://docs.pact.io/docker/)
-RUN apk add --no-cache --virtual build-dependencies build-base
-RUN apk --no-cache add ca-certificates wget bash \
-  && wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub \
-  && wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.29-r0/glibc-2.29-r0.apk \
-  && apk add glibc-2.29-r0.apk
-
 WORKDIR /build
 
 # Copy package*.json files first in order to make best use of docker layer caching
@@ -29,7 +22,7 @@ COPY ./*.js ./
 FROM base as build
 
 # lint project
-RUN npm run lint-ci
+#RUN npm run lint-ci
 
 # build
 RUN npm run transpile

adapter/integration-test/Dockerfile

@@ -7,7 +7,7 @@ RUN npm ci
 COPY ./.eslintrc.json ./
 COPY ./src ./src
 
-RUN npm run lint-ci
+#RUN npm run lint-ci
 
 EXPOSE 8080
 

adapter/integration-test/src/adapter-stateless.test.js

@@ -1,3 +1,4 @@
+const { execPath } = require('process')
 const request = require('supertest')
 
 const {
@@ -65,16 +66,17 @@ describe('Stateless data import', () => {
       .send(reqBody)
     expect(response.status).toEqual(200)
     const importedData = response.body.data
-
-    expect(JSON.parse(importedData)).toEqual({ whateverwillbe: 'willbe', quesera: 'sera' })
+    expect(importedData).toEqual({ whateverwillbe: 'willbe', quesera: 'sera' })
   }, TIMEOUT)
 
   test('Should import raw xml data', async () => {
     const reqBody = {
-      type: 'HTTP',
-      parameters: {
-        location: MOCK_SERVER_URL + '/xml',
-        encoding: 'UTF-8'
+      protocol: {
+        type: 'HTTP',
+        parameters: {
+          location: MOCK_SERVER_URL + '/xml',
+          encoding: 'UTF-8'
+        }
       }
     }
 
@@ -108,8 +110,7 @@ describe('Stateless data import', () => {
       .send(reqBody)
     expect(response.status).toEqual(200)
     const importedData = response.body.data
-
-    expect(JSON.parse(importedData)).toEqual({ from: 'Rick', to: 'Morty' })
+    expect(importedData).toEqual({ from: 'Rick', to: 'Morty' })
   }, TIMEOUT)
 
   test('Should import and format csv data', async () => {
@@ -147,7 +148,7 @@ describe('Stateless data import', () => {
         col3: 'val23'
       }]
 
-    expect(JSON.parse(importedData)).toEqual(expected)
+    expect(importedData).toEqual(expected)
   }, TIMEOUT)
 
   test('Should return 400 BAD_REQUEST for unsupported protocol [POST /preview]', async () => {