Add timstof 2#117
Conversation
add some TODOs to resolve remaining timsTOF dependencies Revert "add some TODOs to resolve remaining timsTOF dependencies" This reverts commit 86d5753.
GeorgWa
left a comment
GeorgWa
left a comment
There was a problem hiding this comment.
Looks good!
Can we get rid of some of the deprecated functions?
| @@ -19,9 +19,5 @@ def load_ms_data(*args, **kwargs): | |||
| raise DeprecationWarning(f"load_ms_data {_DEPRECATION_MSG}") | |||
There was a problem hiding this comment.
why is one reemoved but not the other ones? should we aim for a major release to get rid of all of them?
There was a problem hiding this comment.
the removed code was unused (scope: whole of github ;-))
The deprecationwarnings are for the moved code only.
and yes, at some point we should get rid of all those, until then I think the noise they add is tolerable
There was a problem hiding this comment.
This part was previously used by alphaviz, but it seems that alphaviz used alphatims structure instead of alpharaw
There was a problem hiding this comment.
I think we shall keep alpharaw clean for raw reader purpose.
| This is used to allow subclasses to override the array creation with memory-mapped arrays.""" | ||
| return np.empty | ||
|
|
||
| def _parse_quad_indptr(self) -> None: |
There was a problem hiding this comment.
it seems like this is one of the few complex logic functions left.
So slimed down quite a bit! nice
3 participants
Moves the core parts of the
TimsTOFclass to alpharaw.Code produces same results as before.