Skip to content

fix Wayland ghosting using GL_TEXTURE_SWIZZLE_A #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nschimme merged 1 commit into from
Jun 4, 2026
Merged

fix Wayland ghosting using GL_TEXTURE_SWIZZLE_A #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/opengl/legacy/Legacy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "Legacy.h"

#include "../../display/Textures.h"
#include "../../global/ConfigConsts-Computed.h"
#include "../../global/utils.h"
#include "../OpenGLTypes.h"
#include "../UboManager.h"
Expand Down Expand Up @@ -394,6 +395,17 @@ void Functions::checkError()
void Functions::configureFbo(int samples)
{
getFBO().configure(getPhysicalViewport(), samples);

// WebGL2 lacks native support for texture swizzling
if constexpr (CURRENT_PLATFORM != PlatformEnum::Wasm) {
const GLuint textureId = getFBO().resolvedTextureId();
if (textureId != 0) {
// Fix Wayland ghosting by forcing the alpha channel of the blit target to 1.0.
Base::glBindTexture(GL_TEXTURE_2D, textureId);
Base::glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_A, GL_ONE);
Base::glBindTexture(GL_TEXTURE_2D, 0);
}
}
}

void Functions::bindFbo()
Expand Down
Loading