update installation instructions for Windows/Mac#532
Merged
nschimme merged 5 commits intoMay 18, 2026
Merged
Conversation
- Enable windows-2022 clang target in build-test matrix. - Implement robust recursive discovery of LLVM-MinGW toolchain under C:\Qt. - Set CC and CXX to absolute paths of clang/clang++ executables. - Enable ASAN and UBSAN for Windows Debug builds when using Clang. - Ensure sanitizers remain disabled for Windows GCC to avoid regressions. - Standardize PowerShell exit codes to 1 for failures. * ci: add windows clang target and enable address sanitizer - Enable windows-2022 clang target in build-test matrix. - Implement robust recursive discovery of LLVM-MinGW toolchain under C:\Qt. - Set CC and CXX to absolute paths of clang/clang++ executables. - Enable ASAN and UBSAN for Windows Debug builds when using Clang. - Exclude --compiler-runtime from windeployqt for Clang on Windows. - Ensure sanitizers remain disabled for Windows GCC to avoid regressions.
- Added `/fsanitize=address` and `/Oy-`. - Explicitly removed `/RTC1` as it's incompatible with ASAN. - Set `/INCREMENTAL:NO` for the linker.
…t Edge Update docs/macos.md and docs/windows.md with modern instructions for bypassing security blocks. On macOS, the right-click workaround is replaced by the System Settings "Open Anyway" method, which requires an initial failed launch attempt to trigger the setting. On Windows, explicit steps are added for bypassing Microsoft Edge's download block (Keep -> Show more -> Keep anyway), in addition to SmartScreen and manual file unblocking instructions. The instructions maintain the original descriptive style and layout as requested.
…t Edge Update docs/macos.md and docs/windows.md with modern instructions for bypassing security blocks. On macOS, the right-click workaround is replaced by the System Settings "Open Anyway" method. On Windows, explicit steps are added for bypassing Microsoft Edge's download block and SmartScreen warnings. Note: Previous CI failure in build-snap was a transient network error (Connection failed while fetching libssl3t64) and is unrelated to these documentation changes.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Windows and macOS installation notices to give more concrete, modern instructions for dealing with unsigned/notarized binaries, including browser- and OS-level security prompts, and clarifies that the process is required once per new version. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- On macOS, changing the wording from “might prevent” to “will prevent” could be misleading for users with different Gatekeeper/security settings; consider reverting to softer language like “may prevent it from opening directly.”
- The Windows instructions focus specifically on Microsoft Edge; if users commonly download via other browsers, consider adding a brief, generic note about similar security prompts in other browsers or clarifying that these steps apply when using Edge.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- On macOS, changing the wording from “might prevent” to “will prevent” could be misleading for users with different Gatekeeper/security settings; consider reverting to softer language like “may prevent it from opening directly.”
- The Windows instructions focus specifically on Microsoft Edge; if users commonly download via other browsers, consider adding a brief, generic note about similar security prompts in other browsers or clarifying that these steps apply when using Edge.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
nschimme
deleted the
update-docs-install-instructions-13094904216487701619
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 25.36% 25.36% -0.01%
==========================================
Files 519 519
Lines 43181 43185 +4
Branches 4705 4706 +1
==========================================
Hits 10952 10952
- Misses 32229 32233 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update platform-specific installation documentation for unsigned Windows and macOS builds.
Documentation: