Skip to content

[MSD benchmark] fix(security): validate GitHub user during integration installation#1

Open
khaliqgant wants to merge 5 commits into
msd-benchmark-base/sentry/pr-67876from
msd-benchmark/sentry/pr-67876
Open

[MSD benchmark] fix(security): validate GitHub user during integration installation#1
khaliqgant wants to merge 5 commits into
msd-benchmark-base/sentry/pr-67876from
msd-benchmark/sentry/pr-67876

Conversation

@khaliqgant

Copy link
Copy Markdown

MSD benchmark PR recreated from Martian Code Review Bench.

Source PR: getsentry#67876
Dataset: sentry
Original title: fix(security): validate GitHub user during integration installation

We're adding one more step in the GitHub integration installation pipeline, namely GitHub OAuth2 authorize. This is transparent from the UX perspective as the data exchange happens without user interaction.

The pipeline will now fail in these cases:

  • If there is a mismatch between currently authenticated GitHub user (derived from OAuth2 authorize step) and the user who installed the GitHub app (https://github.com/apps/sentry-io)
  • If there is a mismatch between state parameter supplied by user and pipeline signature
  • If GitHub could not generate correct access_token from the code (wrong or attempt of re-use of code).

In all those cases, this error is shown:
image

@khaliqgant khaliqgant changed the base branch from master to msd-benchmark-base/sentry/pr-67876 May 15, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants