[MSD benchmark] Unified Storage: Init at startup, fix traces, and speed up indexing#10
Open
khaliqgant wants to merge 17 commits into
Open
Conversation
…n by passing span ctx. Update some logging.
… up. Locking the whole function was slowing things down.
khaliqgant
changed the base branch from
main
to
msd-benchmark-base/grafana/pr-97529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSD benchmark PR recreated from Martian Code Review Bench.
Source PR: grafana#97529
Dataset: grafana
Original title: Unified Storage: Init at startup, fix traces, and speed up indexing
Changes:
ResourceServeris created, instead of doing it inside the first gRPC call it receives. This was causing context cancelled errors since the index takes too long to build within the context of the gRPC call.BuildIndexfunction, which was slowing things down when building many namespaces with high concurrency.Notes for reviewer: