Skip to content

[MSD benchmark] feat: 2fa backup codes#2

Open
khaliqgant wants to merge 20 commits into
msd-benchmark-base/cal_dot_com/pr-10600from
msd-benchmark/cal_dot_com/pr-10600
Open

[MSD benchmark] feat: 2fa backup codes#2
khaliqgant wants to merge 20 commits into
msd-benchmark-base/cal_dot_com/pr-10600from
msd-benchmark/cal_dot_com/pr-10600

Conversation

@khaliqgant

Copy link
Copy Markdown

MSD benchmark PR recreated from Martian Code Review Bench.

Source PR: calcom#10600
Dataset: cal_dot_com
Original title: feat: 2fa backup codes

What does this PR do?

  • generate and display backup codes during 2fa setup
  • enable their use during 2fa login flow
  • fix 2fa setup test to include new backup code screen
backup-codes-setup.webm
backup-codes-login.webm

Fixes calcom#9910
/claim calcom#9910

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  1. Setup 2fa to see the generated backup codes
  2. Try to login with them by clicking on "Lost access"

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@khaliqgant khaliqgant changed the base branch from main to msd-benchmark-base/cal_dot_com/pr-10600 May 15, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2FA: download backup code

3 participants