fix: upgrade 6 HTTP URLs to HTTPS in 4 source files#105
Merged
firstdata-dev merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
Fixes partially #103 — upgrade confirmed-working HTTPS URLs: - china-mohrss: data_url - china-moe-higher-education: website + data_url - moe-china: website + data_url - unsd-national-accounts: api_url Skipped 12 URLs where HTTPS fails: - customs.gov.cn (timeout), data.stats.gov.cn (404) - caict.ac.cn (412), mwr.gov.cn (timeout) - dataportal.opendataforafrica.org (403) - caam.org.cn (timeout), cpcif.org.cn (timeout)
firstdata-dev
commented
Mar 29, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 4 个文件 6 处 HTTP→HTTPS，跳过的 12 个 URL 都有合理原因（超时/404/403）。Partially fixes #103。建议合并。
mingcha-dev
reviewed
Mar 29, 2026
mingcha-dev
approved these changes
Mar 29, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #105
HTTP→HTTPS 升级 ✅
修改范围
4 个文件、6 个 URL 升级：
china-mohrssdata_url ✅china-moe-higher-educationwebsite + data_url ✅moe-chinawebsite + data_url ✅unsd-national-accountsapi_url ✅
URL 验证
| URL | 状态 |
|---|---|
| https://www.mohrss.gov.cn/... | 200 ✅ |
| https://www.moe.gov.cn/ | 200 ✅ |
| https://data.un.org/Host.aspx?Content=API | 200 ✅ |
无残留 HTTP ✅
修改后新增行中无 http:// URL
通过 ✅ Partially fixes #103（12 个政府站点不支持 HTTPS 暂保留）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #103
Upgrade 6 confirmed-working HTTPS URLs in 4 files:
china-mohrss: data_url ✅china-moe-higher-education: website + data_url ✅moe-china: website + data_url ✅unsd-national-accounts: api_url ✅Skipped 12 URLs where HTTPS is unavailable:
These 12 remain as HTTP — government sites that don't support HTTPS yet.