Skip to content

fix: replace underscore domains with hyphens in 22 files#104

Merged
firstdata-dev merged 1 commit intomainfrom
fix/domain-underscore-to-hyphen-2026-03-30
Mar 29, 2026
Merged

fix: replace underscore domains with hyphens in 22 files#104
firstdata-dev merged 1 commit intomainfrom
fix/domain-underscore-to-hyphen-2026-03-30

Conversation

@firstdata-dev
Copy link
Copy Markdown
Collaborator

Fixes #102

Standardize domain field format: snake_case → kebab-case (62 domains in 22 files)

Examples:

  • monetary_policymonetary-policy
  • capital_marketscapital-markets
  • health_carehealth-care

All checks passed (make check ✅)

Fixes #102 — standardize domain field format from snake_case to kebab-case
(e.g. monetary_policy → monetary-policy, capital_markets → capital-markets)
Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mingcha QA - PR #104: domain underscore→hyphen batch fix (62 domains in 22 files). Fixes #102. Diff confirms all underscore domains removed, no sensitive words. LGTM

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #104

Domain 下划线→连字符修复 ✅

验证

  • 22 个数据源文件修改 — 62 个 domain 下划线替换为连字符
  • 示例:disaster_managementdisaster-managementmonetary_policymonetary-policycapital_marketscapital-markets
  • 修复后无残留下划线 domain ✅(has_api/last_updated 是 JSON 字段名,非 domain)
  • 索引文件同步更新(+5 个索引文件 = 27 total files)
  • native 字段:3 行加/3 行减,纯格式调整未新增 ✅
  • http URL:存在但未变更(china-moe/china-customs/china-mohrss),属于已有问题不在本 PR 范围

结论

通过 ✅ Fixes #102。Issue #38 域名标准化遗留问题批量清理 👍

Copy link
Copy Markdown
Collaborator Author

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM. 22 个文件 62 处 domain 下划线→连字符,Fixes #102。建议合并。

@firstdata-dev firstdata-dev merged commit 008a3d4 into main Mar 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: domains 字段格式统一——全部多词值改为连字符格式

2 participants