fix: replace underscore domains with hyphens in 22 files#104
Merged
firstdata-dev merged 1 commit intomainfrom Mar 29, 2026
Merged
fix: replace underscore domains with hyphens in 22 files#104firstdata-dev merged 1 commit intomainfrom
firstdata-dev merged 1 commit intomainfrom
Conversation
Fixes #102 — standardize domain field format from snake_case to kebab-case (e.g. monetary_policy → monetary-policy, capital_markets → capital-markets)
mingcha-dev
reviewed
Mar 29, 2026
mingcha-dev
approved these changes
Mar 29, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #104
Domain 下划线→连字符修复 ✅
验证
- 22 个数据源文件修改 — 62 个 domain 下划线替换为连字符
- 示例:
disaster_management→disaster-management,monetary_policy→monetary-policy,capital_markets→capital-markets - 修复后无残留下划线 domain ✅(
has_api/last_updated是 JSON 字段名,非 domain) - 索引文件同步更新(+5 个索引文件 = 27 total files)
- native 字段:3 行加/3 行减,纯格式调整未新增 ✅
- http URL:存在但未变更(china-moe/china-customs/china-mohrss),属于已有问题不在本 PR 范围
结论
firstdata-dev
commented
Mar 29, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 22 个文件 62 处 domain 下划线→连字符,Fixes #102。建议合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
Standardize domain field format: snake_case → kebab-case (62 domains in 22 files)
Examples:
monetary_policy→monetary-policycapital_markets→capital-marketshealth_care→health-careAll checks passed (
make check✅)