Skip to content

Comments

add supprt for the custom auth plugin#376

Open
firefart wants to merge 8 commits intoMISP:masterfrom
firefart:auth
Open

add supprt for the custom auth plugin#376
firefart wants to merge 8 commits intoMISP:masterfrom
firefart:auth

Conversation

@firefart
Copy link
Contributor

@firefart firefart commented Feb 20, 2026

This PR adds support for the CustomAuth plugin. When it's enabled the header is defined in the nginx config so it's passed though to php-fpm and the plugin is configured using the new environment variables.
This comes in handy when you run misp behind an authenticating reverse proxy

Copilot AI review requested due to automatic review settings February 20, 2026 20:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the CustomAuth plugin to enable authentication via custom HTTP headers, typically when MISP is deployed behind an authenticating reverse proxy. The implementation includes environment variable configuration, Docker Compose integration, nginx configuration to pass the custom header to PHP-FPM, and MISP plugin configuration through the setup scripts.

Note: The PR title contains a spelling error: "supprt" should be "support".

Changes:

  • Added CustomAuth plugin environment variables to template.env and docker-compose.yml
  • Implemented nginx configuration to forward custom authentication headers to PHP-FPM
  • Added set_up_custom_auth function to configure the MISP CustomAuth plugin settings
  • Updated README with CustomAuth documentation and usage examples

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
template.env Added commented configuration variables for CustomAuth plugin settings
docker-compose.yml Added CustomAuth environment variables to misp-core service
core/files/entrypoint_nginx.sh Added nginx initialization logic to configure FastCGI parameter for custom auth header; removed trailing whitespace
core/files/configure_misp.sh Added set_up_custom_auth function to enable/disable and configure the CustomAuth plugin in MISP
README.md Added CustomAuth documentation section; fixed JSON and list formatting; removed trailing whitespace

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

firefart and others added 7 commits February 20, 2026 21:29
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant